refactor: when deleting a user, delete the users keys too #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
deleted-user-sshkeys-cleanup
branch
from
38f01f5
to
00e0a56
Compare
shreddedbacon
force-pushed
the
deleted-user-sshkeys-cleanup
branch
from
00e0a56
to
e16d9b8
Compare
rocketeerbkw
requested changes
Jun 28, 2023
shreddedbacon
force-pushed
the
deleted-user-sshkeys-cleanup
branch
from
2f0f903
to
84ab365
Compare
rocketeerbkw
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Currently if a user is deleted, their SSH keys remain in the database.
For example, if we have John Smith and they have an existing account with
jsmith@example.comand their single ssh key attached to the user, but Johns account is accidentally deleted. A new account is created, but when John attempts to re-add the key, it fails because the key is already in the database linked to the previous account.Closing issues
closes #2398