Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make sure we pass the right values back to core when cancelling a task #219

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 5, 2023

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

When cancelling a task that no longer exists in the cluster, we need to pass back some values in the response so the actions-handler knows how to cancel the task properly.

Part of uselagoon/lagoon#3112 but can be merged and released prior to the core pullrequest

@shreddedbacon shreddedbacon marked this pull request as ready for review July 5, 2023 00:40
@shreddedbacon shreddedbacon merged commit d55d5a8 into main Jul 5, 2023
@shreddedbacon shreddedbacon deleted the task-cancellation branch July 5, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant