feat: when a new build comes in, check the namespace for running builds to determine state #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds to determine state
shreddedbacon
force-pushed
the
build-check-on-create
branch
from
83f7877
to
e9d364f
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
As #223 describes, sometimes the kubernetes API can be unresponsive, we've typically only seen this an Azure clusters, and it prevents the controller from reconciling or updating builds properly.
This adds a function to the controller that now when a new build is received, it will check the namespace for running builds, and then attempt to determine if there is a pod associated to that running build or not and then attempt to update the resource and update Lagoon with the change.
Closing issues
closes #223
closes #160