Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce new retain harbor resources labels and deprecate old ones #244

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Dec 19, 2023

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

This introduces new retaining labels that can be added to the harbor secret, or the namespace, that will inform the deletion handler to not clean up resources in harbor when a namespace is deleted.

The following labels can now be added to the namespace or the internal registry secret that Lagoon uses to prevent resources being deleted in harbor when a namespace is deleted in kubernetes. This would mostly used if you're migrating an environment between two clusters that may share the same harbor. If they're different harbors, then you probably don't need to use these at all.

  • harbor.lagoon.sh/retain-repositories
  • harbor.lagoon.sh/retain-robotaccount

These two labels were created for this purpose initially. These labels are now deprecated, and you should use the new ones

  • harbor.lagoon.sh/cleanup-repositories
  • harbor.lagoon.sh/cleanup-robotaccount

@shreddedbacon shreddedbacon marked this pull request as ready for review December 19, 2023 07:49
@shreddedbacon shreddedbacon merged commit 3e7c32f into main Jan 24, 2024
10 checks passed
@shreddedbacon shreddedbacon deleted the retain-harbor-resources-labels branch January 24, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant