chore: apply styles to the correct month #4151
Conversation
| isSelected && "font-bold border-zinc-400", | ||
| !isToday && !isSelected && "border-transparent", | ||
| item.isCurrentMonth && isToday && "border-zinc-400", | ||
| item.isCurrentMonth && isSelected && "bg-success font-bold", |
There was a problem hiding this comment.
Can we remove the bg-success from here. This is causing the date to indicate a memo is present event when there isn't one. With no memo there should only be a border set
expected:
this PR:
There was a problem hiding this comment.
You are correct. In my custom implementation, the logic for isSelected was modified, and the styles were also adjusted accordingly. Apologies for overlooking this and causing issues. Please review this new submission. #4153
By the way, would it be possible to modify the way selectedDate is obtained? Based on the name of this variable, my understanding is that it should be set by selecting a date via a mouse click. However, obtaining it through props instead of state seems to prevent this variable from being updated by mouse clicks.
In the latest version, there's a small issue with the ActivityCalendar component where styles are being applied to the same date in the previous month. Here's some code to fix it.