decorations: prevent interference from other lens extensions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSCode has a long-standing bug microsoft/vscode#33852: multiple decorators on the same line are resolved by whichever was inserted *last*. So you set the **color** in the decoration **type** and the **contentText** in the decoration **options**, another extension might insert its own style in between. This PR implements the suggested workaround: set the `contentText` and `color` at the same time so they'll always appear together. It does so setting everything in the decoration **options**, instead of only a sparse `contentText`. Related: usernamehw#25
|
LGTM. I'll publish once this is tested a bit more. |
|
The upstream issue was fixed so decoration style and text from different extensions are not merged together like before. Now all I'm going to revert this change since it's pretty bad for performance. |
usernamehw
added a commit
that referenced
this pull request
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode has a long-standing bug microsoft/vscode#33852: multiple decorators on the same line are resolved by whichever was inserted last. If you set the color in the decoration type and the contentText in the decoration options, another extension might insert its own style in between, overriding your color.
This PR implements the suggested workaround: set the
contentTextandcolorat the same time so they'll always appear together. It does so setting everything in the decoration options, instead of only a sparsecontentText.I tested this out with the GitLens extension, and it seems to work pretty well! Let me know if you need anything changed. It's unfortunate there's no VSCode fix yet, but this PR seems like a reasonable workaround that makes this extension feel less buggy.
Before
After
Related: #25