Rename refactoring for grammars #418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toinehartman
force-pushed
the
feature/rename-refactoring/grammars
branch
2 times, most recently
from
bc2970e
to
e0b7c41
Compare
rodinaarssen
reviewed
Aug 9, 2024
rodinaarssen
reviewed
Aug 9, 2024
rascal-lsp/src/main/rascal/lang/rascal/tests/rename/Grammars.rsc
Outdated
Show resolved
Hide resolved
…-module' into feature/rename-refactoring/grammars
toinehartman
force-pushed
the
feature/rename-refactoring/grammars
branch
from
e0b7c41
to
91a1c75
Compare
Base automatically changed from
feature/rename-refactoring/cross-module
to
main
September 5, 2024 12:21
toinehartman
force-pushed
the
feature/rename-refactoring/grammars
branch
from
a735cbe
to
cf68cfd
Compare
|
rodinaarssen
approved these changes
Sep 17, 2024
| } catch ParseError(_): { | ||
| return {invalidName(name)}; | ||
| set[IllegalRenameReason] rascalCheckLegalName(str name, set[IdRole] defRoles) { | ||
| set[IllegalRenameReason] tryParseAs(type[&T<:Tree] begin, str idDescription) { |
There was a problem hiding this comment.
NP:
Suggested change
| set[IllegalRenameReason] tryParseAs(type[&T<:Tree] begin, str idDescription) { | |
| set[IllegalRenameReason] tryParseAs(type[&T <: Tree] begin, str idDescription) { |
| , decls = "syntax Foo[&T] = Foo[&T] child &T t;" | ||
| , oldName = "Foo", newName = "Bar"); | ||
|
|
||
| test bool startPoduction() = testRenameOccurrences({0, 1}, "" |
There was a problem hiding this comment.
Suggested change
| test bool startPoduction() = testRenameOccurrences({0, 1}, "" | |
| test bool startProduction() = testRenameOccurrences({0, 1}, "" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements grammar support for the rename refactoring.
Complementary to #397. Allows renaming of productions, constructors, fields/labels in grammars.