Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rascal.tmGrammar.json with generated grammar (commit 6106209 o… #453

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

sungshik
Copy link
Contributor

@sungshik sungshik commented Sep 24, 2024

Original: https://github.com/SWAT-engineering/rascal-textmate/blob/5eda17f209ae6b65924ddf27a77261b49c33880d/vscode-extension/syntaxes/rascal.tmLanguage.json

Changes wrt previous version:

  • Add support for multi-line tags
  • Remove support for multi-line strings -- This is to avoid file-long misclassification of non-string tokens as string tokens, which could result in a bit of a jarring user experience (e.g., introduce a parse error while writing some code on line 635; lose semantic highlighting; TextMate tokenizer misclassifies > on line 11 as string interpolation; the whole screen around line 635 suddenly turns orange)

@DavyLandman
Copy link
Member

Could you in the description of the PR add a small list of changes/improvements to the current textmate?

@sungshik sungshik marked this pull request as ready for review September 30, 2024 06:33
@DavyLandman DavyLandman enabled auto-merge (squash) September 30, 2024 07:26
Copy link

sonarcloud bot commented Sep 30, 2024

@DavyLandman DavyLandman merged commit f274394 into main Sep 30, 2024
12 checks passed
@DavyLandman DavyLandman deleted the update-rascal-tmgrammar-20240924 branch September 30, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants