Improving the UI test runtime #457
Merged
+100
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavyLandman
force-pushed
the
chore/ci-faster-tests
branch
from
85a4fc4
to
a8aae05
Compare
DavyLandman
changed the title
|
Much appreciated, especially since my laptop can't be used for anything else during the wait! |
|
Just one more wait in macosx outline test to make longer. |
|
It was already waiting 70s which should be enough for clicking on an outline item, what it needed was re-clicking, somehow we were too fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI test were taking too long to run, locally and on CI.
I dove in and started measure what was taking long, and bit by bit removing generic sleeps and replacing them by
driver.waitcalls. It also involved tuning memory and splitting of non UI tests to a separate stage.Before (30min total time):
Now (13min total time):