Simplify the debouncer and add tests #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is so much better! My only concern is with the expensive tests. These tests have a lot of value but they also slow down the CI considerably. We should have a discussion if we want to pay this price on every CI run. Do we run the UI tests on a daily basis? If so we might consider moving these tests to that daily build run instead of in the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR: The debouncer used
CompletableFuture.delayedExecutorto schedule futures with a delay. Once scheduled in this way, a delayed future can't be interrupted during the delay. Our use case requires such interruptions, though, so we had a rather complicated workaround.After this PR: The debouncer uses
CompletableFuture.completeOnTimeoutto schedule futures with a delay. Once scheduled in this way, a delayed future can be interrupted during the delay, just by using a "normal" completion. The logic to distinguish between a normal completion and a timeout completion is straightforward. Overall, the debouncer has become a lot simpler.