Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon #8

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Add favicon #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96602a7
Add files via upload
KTrain5169 Sep 11, 2024
c89e22f
Rename favicon.ico to icon.ico
KTrain5169 Sep 11, 2024
6761639
Add icon to build step
KTrain5169 Sep 11, 2024
adee0f9
Add icon to release step
KTrain5169 Sep 11, 2024
4a18276
fix release workflow attempting to obtain icon incorrectly
KTrain5169 Sep 11, 2024
a504ae3
oops been modifying the wrong workflow
KTrain5169 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
pip install pyinstaller

- name: PyInstaller
run: pyinstaller main.py
run: pyinstaller --icon=images/icon.ico main.py

- name: Upload build/
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
pip install pyinstaller

- name: PyInstaller
run: pyinstaller --onefile main.py
run: pyinstaller --onefile --icon=images/icon.ico main.py

- name: List dist directory
run: ls -R dist
Expand Down
Binary file added images/icon.ico
View file
Open in desktop
Binary file not shown.