Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: csv column titles not shown in FF #1477

Merged
merged 2 commits into from
Apr 2, 2020
Merged

fix: csv column titles not shown in FF #1477

merged 2 commits into from
Apr 2, 2020

Conversation

individual-it
Copy link
Contributor

This pull request makes the following changes:

  • makes sure the dropdown list is shown correctly in all browsers

Testing checklist:

  • check the import in Chrome

  • check the import in Firefox

  • I certify that I ran my checklist

Fixes ushahidi/platform#3903 .

Ping @ushahidi/platform

@ushbot
Copy link
Collaborator

ushbot commented Mar 27, 2020

Hey @individual-it,
thank you for your Pull Request.

@rjmackay It looks like this brave person signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Contributor

@rowasc rowasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://bugzilla.mozilla.org/show_bug.cgi?id=40545#c11
so the great firefox label debate ticket started 20 years ago 😭

Anyway, nice find @individual-it , will schedule it for testing.

@rowasc rowasc merged commit e9f59d2 into ushahidi:develop Apr 2, 2020
@individual-it individual-it deleted the dontUseLabel branch April 2, 2020 03:22
@individual-it
Copy link
Contributor Author

@rowasc if you approve #1473 I could make a couple of UI tests for it and make sure they also run in FF and not only in Chrome

@rowasc rowasc mentioned this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in Firefox column titles are not shown during import step 2
3 participants