Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Secondary toolbar and add-post-button look untidy while editing post. #1479

Merged
merged 4 commits into from
Apr 8, 2020

Conversation

noone0212
Copy link
Contributor

@noone0212 noone0212 commented Mar 31, 2020

This pull request makes the following changes:

  • Hiding add-post-button while editing the post.

Testing checklist:

  • Login into the deployment.

  • Go to Data.

  • Select any post to edit.

  • Scroll down to end of page, previously add-post-button and secondary toolbar looked untidy.

  • Now, while editing post add-post-button is removed completely.

  • Saving or cancelling the action bring the button back to its original position.

  • I certify that I ran my checklist

Fixes ushahidi/platform#3905 .

Ping @ushahidi/platform

@noone0212
Copy link
Contributor Author

After Disabling:

Screenshot from 2020-03-31 13-38-06

@Erioldoesdesign
Copy link

From a design pov I don't think this is the best visualisation of a 'disabled' add post button. It's more distracting and users might be 'Why is this transparent floating button here? is it an error?' is my machine broken? the better thing from my pov is to remove it/make fully transparent and have it come back once the click cancel or save. or hide it completely behind the modal.

This semi-transparent low opacity is confusing I think!

@noone0212
Copy link
Contributor Author

noone0212 commented Mar 31, 2020

Screenshot from 2020-03-31 18-05-33
Please review this and it comes back after clicking cancel or save.

@Erioldoesdesign
Copy link

Would definitely want @Angamanga @rowasc and the wider team to be ok with this as I don't have authority to review and clear this kind of amend

@Angamanga
Copy link
Collaborator

@noone0212 The best option would be to completely remove the button while editing, we are trying to remove disabled buttons as best as we can. You could try a ng-show instead 👍

Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🎉. Could you remove the button completely instead when in edit-mode? We are trying to remove disabled buttons as best as we can. You could try a ng-show instead 👍

@noone0212
Copy link
Contributor Author

I have removed it completely. Please see dcbe451.

@Angamanga
Copy link
Collaborator

Angamanga commented Apr 3, 2020

@noone0212 Thank you! Could you also add a testing-checklist to this pr? The steps to do in order to check if this works. That helps our QA-process! 🎉

@rowasc rowasc merged commit 13a0506 into ushahidi:develop Apr 8, 2020
@rowasc rowasc mentioned this pull request Apr 10, 2020
@AmTryingMyBest
Copy link
Contributor

@rowasc this was looked at here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secondary toolbar and add-post-button look untidy while editing post.
5 participants