-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Secondary toolbar and add-post-button look untidy while editing post. #1479
Conversation
From a design pov I don't think this is the best visualisation of a 'disabled' add post button. It's more distracting and users might be 'Why is this transparent floating button here? is it an error?' is my machine broken? the better thing from my pov is to remove it/make fully transparent and have it come back once the click cancel or save. or hide it completely behind the modal. This semi-transparent low opacity is confusing I think! |
Would definitely want @Angamanga @rowasc and the wider team to be ok with this as I don't have authority to review and clear this kind of amend |
@noone0212 The best option would be to completely remove the button while editing, we are trying to remove disabled buttons as best as we can. You could try a ng-show instead 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🎉. Could you remove the button completely instead when in edit-mode? We are trying to remove disabled buttons as best as we can. You could try a ng-show instead 👍
58295c9
to
dcbe451
Compare
I have removed it completely. Please see dcbe451. |
@noone0212 Thank you! Could you also add a testing-checklist to this pr? The steps to do in order to check if this works. That helps our QA-process! 🎉 |
This pull request makes the following changes:
Testing checklist:
Login into the deployment.
Go to Data.
Select any post to edit.
Scroll down to end of page, previously add-post-button and secondary toolbar looked untidy.
Now, while editing post add-post-button is removed completely.
Saving or cancelling the action bring the button back to its original position.
I certify that I ran my checklist
Fixes ushahidi/platform#3905 .
Ping @ushahidi/platform