Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Category label should be hidden when there are no actegories to selec… #282

Merged
merged 1 commit into from
Jul 4, 2016
Merged

Category label should be hidden when there are no actegories to selec… #282

merged 1 commit into from
Jul 4, 2016

Conversation

willdoran
Copy link
Contributor

@willdoran willdoran commented Jul 4, 2016 •
edited
Loading

This pull request makes the following changes:

  • Updated category fieldset to display only when categories available

Test these changes by:

  • When adding/editing a post with categories in the system then you should see categories appear on the post add/edit view
  • When adding a post with no cateogries in the system then you should see no category label on the view

Fixes ushahidi/platform#1155

Ping @ushahidi/platform

This change is Reviewable

@willdoran willdoran added this to the Sprint 7 milestone Jul 4, 2016
@rjmackay rjmackay temporarily deployed to ushahidi-platform-maste-pr-282 July 4, 2016 14:37 Inactive
@willdoran willdoran mentioned this pull request Jul 4, 2016
Closed
@coveralls
Copy link

coveralls commented Jul 4, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 51.623% when pulling da735fc on 1155-category-label into 4ca14b9 on develop.

@rjmackay rjmackay merged commit 2655d74 into develop Jul 4, 2016
@rjmackay rjmackay deleted the 1155-category-label branch September 8, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rjmackay rjmackay

@jasonmule jasonmule

Labels
None yet
Projects
None yet
Milestone
Sprint 7
Development

Successfully merging this pull request may close these issues.
4 participants
@willdoran @coveralls @rjmackay @jasonmule