-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a ‘Skip to Content’ link #2746
Provide a ‘Skip to Content’ link #2746
Comments
@Angamanga @sethburtonhall is this in the correct pipeline ? (Ready for Dev) |
@rowasc Moving to ready for spec |
@Angamanga Does this require any design work? I'm not sure it does but worth checking! |
@sethburtonhall @Angamanga I'm stuck on the acceptance criteria section, how do we test this work? |
@willdoran (not sure this is helpful but) you should be able to use tab to get to the 'skip to content' as the second or third 'tab' (as in the keyboard button tab) the first should be content/title that orientates the non-sighted user as to what is on the whole site. In our case I would suggest it go: 1 - Deployment name Keen to get other folks input though @justinscherer Also I can ask some of the inclusivity community around these parts 👍 |
@Erioldoesdesign Thanks that's very helpful I'll include that as the acceptance criteria and request reviews from @justinscherer @Angamanga and yourself. |
@Erioldoesdesign @Angamanga should the skip to content link be visible to all users? or similar to the github approach, only visible if you tab to it? |
@willdoran @Erioldoesdesign @rjmackay When I first wrote this issue, I was thinking about screen-readers only and hiding the skip-to-content link to everybody else. But it actually makes sense to keep it visible for all users since tabbing around everywhere is annoying. But that said, since we don't manage tabbing in the "old" ui right now, I think it makes more sense just keeping it for the screen-reader-users and hiding it for everyone else = no design needed. For the ui-refresh, we should include a skip-link for everybody. Suggestion: We'll focus on screen readers and hide the link in this cycle and add I will add an issue for design in the ui-refresh-epic? We could also use something similar to this: http://paypal.github.io/skipto/ |
@Angamanga Sounds like a great approach, can you update the spec with corrections to what I made? |
@rjmackay I don't think it's very useful in our case for all users. Visible only if tabbed would be great |
I am currently trying to set up the dev-environment locally on my computer, I have gone through a lot of steps and I am at the point where I need to run 'vagrant up'. I did that but I am getting this error; I found possible solutions here https://stackoverflow.com/questions/44463987/homestead-installation. I am a little confused as to which one to use as I don't want to spoil what I have done previously. Please I need some help @Angamanga |
@onyeepeace Make sure you are in the platform-api folder before running vagrant up, its in this folder the Homestead.yaml file is. |
hey @Angamanga who is assigned to this one? It's not clear and I'm worried maybe there's two folks working on it at the same time? @bimbolabuari I'm assuming you are working on this one no? |
Hi @rowasc, Yes, I am working on it. Thanks for assigning it to me. |
Hi @rowasc and @Angamanga, Please I need your help on where to implement the "skip to content" link, as it is not clear since the root page (http://localhost:8001/views/map) and other links I have access to doesn't seem to have main content Thanks. |
@bimbolabuari in the case of the map, it's also unclear to me how we define content. I assume it's the posts in the map. In the data view however, "skip to content" should "take" the user directly to listen/read the first post card on the left. |
@rowasc @bimbolabuari Lets start with the data-view, that is a huge win and once we have decided how to handle the map we can add it to that view :). |
@rowasc @Angamanga Thanks for the clarification, I will start with the data-view however there is no seed data for the post view, and am having an issue creating a new post so as to get the idea of skipping to the main content for the view. Please is there a way I can create a new post from the backend?
|
hrm that's odd what kind of setup do you have ? I've never run into this before :/ |
@rowasc I am using vagrant set up for backend. Running
I removed the location field from the create post fields to check if the issue is with the location field only (
|
pinging @Angamanga @rowasc |
@rowasc Could you please check? |
@bimbolabuari that's odd, I think I can link this to a mysql 8 thing but... I don't see why you'd be in mysql8 if you're using our vagrant box. |
@rowasc checking |
ah , that's odd. Are you using the same vagrant box we are using, or the new/standard homestead box? |
Not sure if I am using the same vagrant box. However, I followed the setup instruction in the documentation |
@bimbolabuari no you should not need to change the version of vagrant itself. I'm confused since that version of homestead is even lower than the one I have. You may be able to make the change in Homestead.yml to avoid mysql8
And if that fails I guess uninstalling mysql8 in the box itself and reinstalling manually will do the trick (not ideal .. I definitely need to look more into why the setup is defaulting to mysql8 now) |
@rowasc, I made the changes in homestead.yml features:
- mysql8: false and also remove the vagrant box and re-provisioned it but still unable to create a post. |
@rowasc, I have been able to create a new post! I discovered that the default version for mysql is version 8 for the latest version of laravel homestead box here. So i changed the version to # vendor/laravel/homestead/scripts/homestead.rb
config.vm.box_version = settings["version"] ||= "9.6.1" This adds ubuntu 18 and mysql 5.7 ( Thank you @rowasc! Can I open a pull request to add this to the documentation? |
Hi there! sorry I'm stepping in late! I noticed some comments on how skip to content on map should be handled and I'm wondering how important it is to have the skip to content read out the about information about the deployment first (the information that sits under the logo circle) For sure, on a first users visit the info blurb first to better understand what the deployment is doing to give context to the posts. I wonder if we can cookie know that user has visited recently and skip reading out the blurb...hmm For data view...this is a bit of an odd journey right? unless the link that a user clicks takes them straight to the deployment data view (it defaults to map right?) then the user needs to get through the nav items to select data view to then get to this skip to content link. Once on the data view page what's being done is perfect, there should be a way to get into the first post in the list, open, then read through the info but there should also be an indication of how much data is in a single post so perhaps the screen readers need to read out the fields included in the first post and confirm they want to read and then move on to second post. I'm happy to either like, chat through or perhaps do some prototypes/documents of the 'flow' of this but super happy this is being started 😄 |
Overview
Screen readers announce all of the links on the page to the user, in order. To help navigation, provide a way for them to bypass parts of each page, for example such as long navigation links in mode-bar, filter-bar in the toolbar and each map-icon.
Requirements
https://www.wuhcag.com/bypass-blocks/
Acceptance criteria
1 - Deployment name
2 - Deployment description
3 - Skip to content (we need to define what we consider 'content' here I would suggest that we define content as 'posts' an go right to the pins/posts)
Aha! Link: https://ushahiditeam.aha.io/features/PROD-372
The text was updated successfully, but these errors were encountered: