Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2746: Add 'skip to content' styles #260

Merged

Conversation

bimbolabuari
Copy link
Contributor

@bimbolabuari bimbolabuari commented Nov 1, 2020

Description of Issue

Screen readers tend to announce all of the links on the page to the user, in order to help with accessibility to bypass parts of each page, for example, navigation links in the mode-bar, filter-bar in the toolbar and get to main content, skip to content is needed.
Skip to content styles provides help with the positioning of the skip to content link, adding visibility, font properties, border properties.

Proposed Solution

Skip to content styles is implemented in the upper left corner that says “Skip to Content.”, It is hidden and then brings into view when it is focused or active. It's the first thing that appears after the page is being loaded and tabbed on, it skips to the first postcard which is the most important of the page on the data view. it is only visible when tabbed on importantly for screen-readers only and hiding the skip-to-content link to everybody else.

Testing

The testing was done manually by tabbing on the page which in turn activates the skip to content button as shown in the screenshot section below. The gulp test command was run to make sure no test is broken/affected by the changes.

Testing checklist

  • I certify that I ran my checklist

Post views

  • Go to data posts
  • Tab on page
  • "Skip to content" will be visible on top left side
  • Tab on "skip to content" button
  • Focus is on "skip to content" link
  • Press tab or space bar
  • Focus is on first post card

Screenshots

Current Proposed changes
skip-to-content-pp add-skip-to-content-pp

Fixes ushahidi/platform#2746

Ping @ushahidi/platform @Angamanga @rowasc

@bimbolabuari bimbolabuari changed the title Add skip to content styles Fix 2746: Add 'skip to content' styles Nov 1, 2020
@Angamanga Angamanga changed the base branch from master to v4.4.4 November 20, 2020 14:08
@Angamanga Angamanga merged commit 806e02c into ushahidi:v4.4.4 Nov 20, 2020
@AmTryingMyBest
Copy link

QA'd, passes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a ‘Skip to Content’ link
3 participants