Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AES-ECB MCT test with empty "pt" in excepted result #11

Closed
AndrewHYang opened this issue Sep 23, 2020 · 3 comments
Closed

AES-ECB MCT test with empty "pt" in excepted result #11

AndrewHYang opened this issue Sep 23, 2020 · 3 comments
Assignees

Comments

@AndrewHYang
Copy link

environment
Demo

testSessionId
/acvp/v1/testSessions/100283

vsId
291188

There are three Monte Carlo tests, with "tgId" as 16, 17, and 18.
16 - keyLen = 128
17 - keyLen = 192
18 - keyLen = 256
In the expected response file, both cases 16 and 18 include an empty "pt" item before the "resultsArray". For example:
"tgId": 16,
"tests": [
{
"tcId": 1070,
"pt": "",
"resultsArray": [
...
Case 17 (keyLen = 192) does not include this empty "pt" item. Should all three cases be consistent in their inclusion or exclusion of the empty "pt"? It seemed odd that only the 192 keyLen did not include it, while the other two cases did.

@Kritner
Copy link
Contributor

Kritner commented Sep 23, 2020

Hmm... that is strange. I have not had any luck reproducing this, but I do see the two empty "pt": ""s in the expected answer file for this VS. I just tried a few vector sets myself with your registration and did not encounter the behavior.

There doesn't seem to be any relevant changes to the system in the time between when your vector set was generated, and today. The only thing I can think of is our "precomputed values" process at some point was saving the "pt": "". It doesn't hurt anything by being there, but it is confusing. That expected results file should still pass as far as I can tell, were you to POST it.

I'll try to identify if these sorts of precomputed values do exist on this environment, but you should still be safe to attempt to submit that file, it just has an extra property in it that will be ignored.

@Kritner Kritner self-assigned this Sep 23, 2020
@Kritner
Copy link
Contributor

Kritner commented Sep 28, 2020

This change is on demo (though it wouldn't have impacted your already existing test session)

@Kritner
Copy link
Contributor

Kritner commented Sep 30, 2020

this change is now on production https://github.com/usnistgov/ACVP-Server/releases/tag/v1.1.0.12

@Kritner Kritner closed this as completed Sep 30, 2020
celic pushed a commit that referenced this issue Jan 7, 2022
- No longer serialize "pt"/"ct" in the results file for MCT cases (at the root of the test case, the results array is unaffected)
- #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants