Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACVP-AES-XTS occasionally provides out of range sequence numbers #354

Closed
v-roackerman opened this issue Sep 3, 2024 · 5 comments
Closed
Assignees
Milestone

Comments

@v-roackerman
Copy link

environment
Demo

testSessionId
535961

vsId
2509629

Algorithm registration
{
"algorithm": "ACVP-AES-XTS",
"revision": "2.0",
"direction": [
"encrypt",
"decrypt"
],
"keyLen": [
128,
256
],
"payloadLen": [
512,
4096,
65536
],
"tweakMode": [
"number"
],
"dataUnitLenMatchesPayload": true
}

Endpoint in which the error is experienced
https://[acvpUrl]/acvp/[endpoint] GET
Unsure what you mean.

Expected behavior
A sequence number in a range between 0 and 255 be provided.

Additional context
ACVP-AES-XTS ACVP documentation dictates that when the tweakMode field is set to “number”, the sequence number shall be between 0 and 255.
We sometimes get 256 from the NIST demo server forcing our code to exit.

https://pages.nist.gov/ACVP/draft-celi-acvp-symmetric.html#name-test-groups

@jbrock24
Copy link
Collaborator

jbrock24 commented Sep 4, 2024

I found the issue and have fixed it. It will go out with the next version. We'll post here when it's available on demo. Thanks for reporting the issue!

@jbrock24 jbrock24 self-assigned this Sep 4, 2024
@livebe01 livebe01 added this to the v1.1.0.36 milestone Sep 11, 2024
@livebe01
Copy link
Collaborator

livebe01 commented Oct 7, 2024

Hi @v-roackerman, we just deployed the fix for this issue to Demo as part of the v1.1.0.36 release. Are you be able to test it to confirm? Thank you.

@v-roackerman
Copy link
Author

It is rare that I see it. In fact, after the first time, it was two more months before I saw it again to provide this treport.
I will run it regardless as part of my job and report if not fixed.

@livebe01
Copy link
Collaborator

livebe01 commented Oct 7, 2024 via email

@livebe01
Copy link
Collaborator

The fix for this issue has been deployed to ACVTS Prod as part of the v1.1.0.36 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants