Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP800-56C rev 1 HKDF test spec #1048

Closed
smuellerDD opened this issue Oct 27, 2020 · 7 comments
Closed

SP800-56C rev 1 HKDF test spec #1048

smuellerDD opened this issue Oct 27, 2020 · 7 comments
Assignees

Comments

@smuellerDD
Copy link
Contributor

The HKDF test spec may need a bit of love.

Chapter on test vectors:

  • algorithmID not present

  • description of l missing - note, looking at the expected value, this field seems to be a byte value and not a bit value

@smuellerDD
Copy link
Contributor Author

SP800-56C rev 1 HKDF testing successfully completed - vsID 365582

@Kritner
Copy link
Contributor

Kritner commented Oct 28, 2020

description of l missing - note, looking at the expected value, this field seems to be a byte value and not a bit value

Can you elaborate on this about the byte vs bit value? the value l itself as registered and in the vector set information should represent the number of bits to derive keying material for, represented as an int. When "plugged into" fixed info that same int value that represents the number of bits to derive should be represented as a 32 bit bitstring. So an l of 512 becomes "00000400" as the "portion" of the fixed info that represents l (assuming that l is included as a part of the fixed info).

@smuellerDD
Copy link
Contributor Author

smuellerDD commented Oct 28, 2020 via email

@Kritner
Copy link
Contributor

Kritner commented Nov 4, 2020

Thanks @smuellerDD I'll make an update to the specification to account for l, and make a correction on our side so that l represents the DKM length in bits rather than the current (and incorrect) bytes.

@Kritner
Copy link
Contributor

Kritner commented Nov 13, 2020

This change will be on demo from release v1.1.0.14 after the scheduled maintenance.

@smuellerDD
Copy link
Contributor Author

Confirmed, working.

@Kritner
Copy link
Contributor

Kritner commented Dec 1, 2020

This change is on production in release v1.1.0.14

celic pushed a commit to usnistgov/ACVP-Server that referenced this issue Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants