Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAS ECC Ar3 Full MQV "Specified argument was out of the range of valid values." after addition of KMAC in KC list #1090

Closed
mwcw opened this issue Dec 10, 2020 · 4 comments
Assignees

Comments

@mwcw
Copy link

mwcw commented Dec 10, 2020

Hi,

We are getting:
[{"acvVersion":"1.0"},{"error":"Specified argument was out of the range of valid values. (Parameter \u0027capacity\u0027)"}]
After adding:

"KMAC-256": {
                  "macLen": 512,
                  "keyLen": 256
                },

and

"KMAC-128": {
                  "macLen": 256,
                  "keyLen": 128
                },

to the capabilities request.

I could not find "capacity" in the spec.

I have attached the request and responses.

Archive.zip

Please let me know if you need any more information.

MW

@Kritner
Copy link
Contributor

Kritner commented Dec 10, 2020 via email

@Kritner Kritner self-assigned this Dec 10, 2020
@Kritner
Copy link
Contributor

Kritner commented Dec 10, 2020

Looks like my suspicion was correct. The fix put in (and subsequent guards within our KMAC implementation) from usnistgov/ACVP-Server#43 caused this response from the server. Rather than create incorrect values due to a bad KMAC construction it threw an exception - overall better behavior IMO.

Thanks for the issue report, I'll get a fix in.

@Kritner
Copy link
Contributor

Kritner commented Dec 10, 2020

The change is on demo, I'll update again once on production. I re-ran the generation request from the vector set in the original issue, and the files have been generated.

@Kritner
Copy link
Contributor

Kritner commented Dec 10, 2020

This change is now on demo and production in release v1.1.0.14 hotfix 2

@Kritner Kritner closed this as completed Dec 11, 2020
celic pushed a commit to usnistgov/ACVP-Server that referenced this issue Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants