Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move several KAS/KTS-IFC properties nested under scheme to the root of the registration #945

Closed
Kritner opened this issue Aug 11, 2020 · 0 comments · Fixed by #946
Closed
Assignees

Comments

@Kritner
Copy link
Contributor

Kritner commented Aug 11, 2020

Last time we checked there wasn't any actual cases of testing of the IFC flavors of KAS/KTS on demo, and due to that I had planned on changing the registration around a bit, namely:

Current KAS IFC registration:

root
    scheme1
        key generation methods
            modulo
            etc...
        etc...
    scheme2
        key generation methods
            modulo
            etc...
        etc...

where the above would allow a specifying of "key generation methods" on a "per scheme basis" where each "key generation method" could support multiple (and potentially differing) sets of modulo.

I'm not sure if it makes sense to have this complexity in the registration, and I've brought it up internally to perhaps change this part of the registration:

root
    scheme1
    scheme2
    key generation methods
    supported modulo
    etc...

so that the key generation methods are independent of the schemes, and the modulo are independent of the key generation methods.

I'm pretty sure this is a valid assumption to make, but up until now we hadn't had anyone testing this particular algorithm.

Originally posted by @Kritner in #942 (comment)

Kritner added a commit to Kritner/ACVP that referenced this issue Aug 11, 2020
…he registration

- modulo, keyGenerationMethods, and fixedPubExp were moved to the root
- fixes usnistgov#945
@Kritner Kritner self-assigned this Aug 11, 2020
@Kritner Kritner added this to the v1.1.0.11 Release milestone Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant