Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks to overcome Travis test failures #204

Merged
merged 4 commits into from
Jan 27, 2017

Conversation

wd15
Copy link
Collaborator

@wd15 wd15 commented Jan 25, 2017

Address #185

wd15 added 2 commits January 25, 2017 16:48
The notebook tests always fail on Travis CI due to the name of the
conda environment with

  jupyter_client.kernelspec.NoSuchKernel: No such kernel named conda-root-py
@wd15 wd15 requested a review from tkphd January 25, 2017 23:36
@wd15 wd15 added the bug label Jan 25, 2017
@wd15 wd15 added this to the v0.3.1 milestone Jan 25, 2017
@tkphd
Copy link
Collaborator

tkphd commented Jan 26, 2017

It builds and looks OK, so I am prepared to merge. For 7960052, would specifying the kernel (source) resolve this without excluding the notebooks from testing?

@wd15
Copy link
Collaborator Author

wd15 commented Jan 26, 2017

Wait then, I'll try that. I did see that issue, but I didn't read it very carefully. Wait on this for now.

@tkphd tkphd assigned wd15 and unassigned tkphd Jan 26, 2017
@wd15
Copy link
Collaborator Author

wd15 commented Jan 27, 2017

I changed the name of the Python kernel and it seemed to work. This can be merged now.

@wd15 wd15 assigned tkphd and unassigned wd15 Jan 27, 2017
@tkphd tkphd merged commit dc48697 into usnistgov:master Jan 27, 2017
@tkphd
Copy link
Collaborator

tkphd commented Jan 27, 2017

That seems better. Thanks!

@wd15 wd15 deleted the fix-tests branch February 2, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants