Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and homologate syntax #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CristopherA96
Copy link

Hi, I am Cristopher,

I was recently working with this repository and had made a few small changes locally, some of these changes have been recently released, such as np.float -> float commit.

First change:
In addition to these changes, I consider that the batch/job_template.sh script file has obsolete instructions such as python2 "batch/train_risk_slim.py --help, since in the script you use python3 to run the tool, so when using python2 it does not works, and may cause confusion for some novice users.

Second change:
In the same way, in the solution_pool.py file, there are some warnings that are related to the use of the "is" syntax in python3, so checking the logic I think that "==" adapts to the functionality that you want to give with "is" syntax.

These minor changes can give you a better understanding of the instructions and what is done in the repository.

As I mentioned, these are changes that for non-advanced users can cause confusion.

Thanks for your time, and I hope this will be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant