Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caniuse-lite and drop unused browserslist IE string #6145

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

anselmbradford
Copy link
Contributor

Moved from #5889

Summary

  • This updates the caniuse-lite database, which was last updated 4 months ago (updated via npx update-browserslist-db@latest).
  • This removes the IE 11 string from the .browserslistrc config file. You can see via running npx browserslist that the IE 11 string does not make a difference, because IE 11 is included in the dead browsers set, and this project's browserslist config specifies not dead (see https://github.com/browserslist/browserslist?tab=readme-ov-file#full-list).

Dependency updates

Dependency name Previous version New version
caniuse-lite 1.0.30001570 1.0.30001669

@anselmbradford anselmbradford changed the title Update to caniuse-lite@1.0.30001669 Update caniuse-lite and drop unused browserslist IE string Oct 23, 2024
@amyleadem amyleadem added the Context: IE11 Related to IE11 support label Oct 23, 2024
@amyleadem
Copy link
Contributor

amyleadem commented Oct 23, 2024

Note

This work originates from PR #5889.

In that PR, @mejiaj added this helpful comment that highlights the open question related to IE11:

Thanks @anselmbradford for this update.

Todo

  • Confirm if we want to get rid of IE11
  • Compare how output is affected in compiled CSS (both in size and prefixes)

Supporting IE 11 adds 1KB to uswds.css and will affect the following:

/* uswds.css */

.usa-js-no-click {
  pointer-events: none;
  -webkit-user-select: none;
  -moz-user-select: none;
+  -ms-user-select: none;
  user-select: none;
}
.usa-js-no-click .usa-modal,
.usa-js-no-click .usa-modal * {
  pointer-events: auto;
  -webkit-user-select: text;
  -moz-user-select: text;
+  -ms-user-select: text;
  user-select: text;
}

.usa-pagination__overflow {
  align-items: center;
  align-self: stretch;
  display: inherit;
  -webkit-user-select: none;
  -moz-user-select: none;
+  -ms-user-select: none;
  user-select: none;
  padding: 0.5rem;
}

+ .usa-combo-box__input:disabled:-ms-input-placeholder,
+ .usa-combo-box__input[aria-disabled="true"]:-ms-input-placeholder {
+   opacity: 1;
+ }

.usa-input-prefix,
.usa-input-suffix {
  position: absolute;
  color: #71767a;
  line-height: 0;
  padding: 0 0.5rem;
  -webkit-user-select: none;
  -moz-user-select: none;
+  -ms-user-select: none;
  user-select: none;
  white-space: nowrap;
}

To keep support for IE11, we will need to reorder the .browserlistrc file so that IE11 appears after "not dead". We will need to discuss if we want to make this change.

@amyleadem amyleadem added Needs: Discussion We need to discuss an approach to this issue and removed Needs: Discussion We need to discuss an approach to this issue labels Oct 23, 2024
@amyleadem
Copy link
Contributor

amyleadem commented Oct 29, 2024

Update

The USWDS core team discussed this and confirmed that formally removing IE 11 from the .browserslistrc is the appropriate path.

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks @anselmbradford for this submission and your helpful PR description.

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Confirming browsers list.

npx browserslist
➜ npx browserslist
and_chr 130
and_ff 130
and_qq 14.9
and_uc 15.5
android 130
chrome 130
chrome 129
chrome 128
chrome 127
edge 130
edge 129
edge 127
firefox 132
firefox 131
ios_saf 18.0
ios_saf 17.6
ios_saf 17.5
kaios 3.0-3.1
kaios 2.5
op_mini all
op_mob 80
opera 114
opera 113
safari 18.0
safari 17.6
samsung 25
samsung 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context: IE11 Related to IE11 support
Projects
Status: Fed Final Review
Development

Successfully merging this pull request may close these issues.

3 participants