Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use with terraform v0.12.x and add metadata options for aws_launch_config #182

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

jaysiyani
Copy link
Contributor

This commit will allow terrafying-components to be compatible with terraform v0.12.x.
If you're still using terraform v0.11.x please use an older version of terrafying-components.
bundle exec terrafying json xxx.rb > xxx.tf.json is required when using terraform v0.12.x

Changes:
Added metadata_option for aws_launch_configuration. (currently requires custom aws provider)
Added additional keys required for security_groups.
Changed the use of hexdigest to bubblebabble for aws_lb. (terraform v0.12.0 A name must start with a letter or underscore)

@jaysiyani
Copy link
Contributor Author

i will tag this release 1.20.0-rc1 until hashicorp takes a look at this PR. This will only be used with a custom terraform-aws-provider for now.

Copy link
Contributor

@rhysemmas rhysemmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we tag with 2.0.0 (or 2.0.0-rc1 if WIP) if we are making an incompatible API change?

@jaysiyani
Copy link
Contributor Author

jaysiyani commented Aug 25, 2020

LGTM, but should we tag with 2.0.0 (or 2.0.0-rc1 if WIP) if we are making an incompatible API change?

Yeh makes sense, i'll tag with 2.0.0 until we stop using the custom provider for aws.

@jaysiyani jaysiyani merged commit 036a3d0 into master Aug 25, 2020
@jaysiyani jaysiyani deleted the add-metadata-options branch August 25, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants