Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Fix warning message in orbit setting #455

Merged
merged 2 commits into from
Jul 18, 2023
Merged

[hotfix] Fix warning message in orbit setting #455

merged 2 commits into from
Jul 18, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Jul 15, 2023

Overview

[hotfix] Fix warning message in orbit setting

Issue

#439

Details

  • Move the warning message to the correct place
  • Simplify the if statements

Validation results

The issue was solved in the same setting.

Scope of influence

patch

Supplement

NA

Note

NA

@200km 200km added priority::high priorityg high gui graphical user interface dynamics dynamics calculation patch backwards compatible bug fixes labels Jul 15, 2023
@200km 200km added this to the Minor update v6.3.0 milestone Jul 15, 2023
@200km 200km self-assigned this Jul 15, 2023
@200km
Copy link
Member Author

200km commented Jul 15, 2023

２連続でpatchバージョンあげるの面倒なので、下記PRとまとめて v6.2.1にあげようと思います。

#454

@200km 200km linked an issue Jul 15, 2023 that may be closed by this pull request
Prevent showing WARNING when orbit default mode is chosen #439
Closed
1 task
suzuki-toshihir0
suzuki-toshihir0 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@suzuki-toshihir0 suzuki-toshihir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正いただきありがとうございます！

Base automatically changed from hotfix/fix-ini-file-path to main July 18, 2023 05:23
@200km 200km merged commit 5cb727e into main Jul 18, 2023
51 checks passed
@200km 200km deleted the hotfix/fix-warning-showing-in-orbit-setting branch July 18, 2023 05:24
@200km 200km mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-toshihir0 suzuki-toshihir0 suzuki-toshihir0 approved these changes

@sksat sksat Awaiting requested review from sksat sksat is a code owner

@seki-hiro seki-hiro Awaiting requested review from seki-hiro

@conjikidow conjikidow Awaiting requested review from conjikidow

Assignees

@200km 200km

Labels
dynamics dynamics calculation gui graphical user interface patch backwards compatible bug fixes priority::high priorityg high
Projects
S2E
Archived in project
Milestone
Minor update v6.3.0
Development

Successfully merging this pull request may close these issues.

Prevent showing WARNING when orbit default mode is chosen
2 participants
@200km @suzuki-toshihir0