[Hotfix] Remove bug when center object is not the earth #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200km
added
bug
suzuki-toshihir0
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove bug when center object is not the earth
Issue
NA
Details
When we select the center object as moon or other planets, the calculation was crushed because the center body rotation was not defined.
I modified to define non-rotation behavior when the center object is not the earth.
Validation results
I confirmed that the case of
center_object = MOONand the bug was removed.Scope of influence
patch, for deep space users.
Supplement
I made a related issue.
#462
Note
NA