Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for RW initial rotation #494

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix for RW initial rotation #494

merged 1 commit into from
Oct 2, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Sep 26, 2023

Overview

Fix for RW initial rotation

Issue

#381

Details

The initial rotation speed was used in RW_ODE, but the first log output shows the speed is zero. I fixed to insert the initial value to the source value of the log output.

Validation results

  • 100 rad/s initial rotation speed and motor drive flag = 0
    • The rotation speed reach to zero due to the friction

image

  • 100 rad/s initial rotation speed and motor drive flag = 1
    • The rotation speed is kept as 100 rad/s because the RW controls the rotation speed.

image

Scope of influence

Patch update

Supplement

NA

Note

NA

@200km 200km added priority::medium priority medium component component emulation patch backwards compatible bug fixes labels Sep 26, 2023
@200km 200km added this to the Major Update for v7.0.0 milestone Sep 26, 2023
@200km 200km requested a review from sksat as a code owner September 26, 2023 08:42
@200km 200km self-assigned this Sep 26, 2023
@200km 200km requested a review from a team as a code owner September 26, 2023 08:42
@200km 200km requested review from suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team September 26, 2023 08:42
@200km 200km linked an issue Sep 26, 2023 that may be closed by this pull request
Add initial angular velocity for reaction wheel #381
Closed
1 task
suzuki-toshihir0
suzuki-toshihir0 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@suzuki-toshihir0 suzuki-toshihir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちら，意図通りの修正になっていると思います．ありがとうございます，

Base automatically changed from feature/remove-initialize-for-components to develop October 2, 2023 07:15
@200km 200km merged commit b394c26 into develop Oct 2, 2023
41 checks passed
@200km 200km deleted the feature/fix-for-rw-initial-rotation branch October 2, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-toshihir0 suzuki-toshihir0 suzuki-toshihir0 approved these changes

@conjikidow conjikidow conjikidow approved these changes

@sksat sksat Awaiting requested review from sksat sksat is a code owner

@t-hosonuma t-hosonuma Awaiting requested review from t-hosonuma t-hosonuma is a code owner automatically assigned from ut-issl/aocs

Assignees

@200km 200km

Labels
component component emulation patch backwards compatible bug fixes priority::medium priority medium
Projects
S2E
Archived in project
Milestone
Major Update for v7.0.0
Development

Successfully merging this pull request may close these issues.

Add initial angular velocity for reaction wheel
3 participants
@200km @suzuki-toshihir0 @conjikidow