Refactor logger class impl with std::filesystem #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
N/A
Description
Logger
class with C++17std::filesystem
#ifdef
for platform supportLogger
does not dump log files iflogs
directory does not existTest results
logger directory & log files creation test
Impact
Logger
class implementationLogger
class interfacestd::string
&std::filesystem::path
can be converted, so the actual change cost is very small