Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noise characteristics of the qpd sensor #82

Merged

Conversation

TomokiMochizuki
Copy link
Member

概要

Add noise characteristics of qpd sensor

Issue

  • 関連する issue

詳細

Add noise characteristics of qpd sensor

検証結果

四分割センサの出力値の履歴

image

実際の変位と観測した位置変位の履歴
[注意]: 位置変位誤差があるのは、衛星間距離が10mなのに対し、現在位置観測を逆算する際に使用している値が衛星間距離1.5mの時の値であるため.

image

位置変位の観測誤差の履歴

image

影響範囲

XX系の動作がガラッと変わる,とか.

補足

何かあれば

注意

  • 関連する Projects が存在する場合,それの紐付けを行うこと
  • Assignees を設定すること
  • 可能ならば Reviewers を設定すること
  • 可能ならば priority ラベルを付けること

@TomokiMochizuki TomokiMochizuki changed the title Add noise characteristics of qpd sensor Add noise characteristics of the qpd sensor Jan 10, 2024

// Noise parameters
libra::NormalRand qpd_sensor_output_random_noise_; //!< Normal random for QPD sensor output value
double qpd_standard_deviation_scale_factor_m_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NITS] コメントをお願いします。

double temp = qpd_sensor_sensitivity_coefficient_V_W_ *
laser_emitter->CalcIntensity_W_m2(distance_from_beam_waist_m, deviation_from_optical_axis_m) * qpd_sensor_integral_step_m_ *
qpd_sensor_integral_step_m_;
double temp1 = qpd_sensor_sensitivity_coefficient_V_W_ *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NITS] tempという変数名だとどんな計算かわからないので、せめてコメントなどでコードの意図がわかるようにしてもらいたいです。

@TomokiMochizuki TomokiMochizuki merged commit 27f7c03 into ut-issl:develop Jan 13, 2024
8 checks passed
@TomokiMochizuki TomokiMochizuki deleted the feature/add_noise_of_qpd_sensor branch January 13, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants