Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake 3.18's built-in CMAKE_CUDA_ARCHITECTURES support #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vancemiller
Copy link
Contributor

allows Altis to build with Cuda 10.1's nvcc

allows altis to build with Cuda 10.1's nvcc
@vancemiller vancemiller self-assigned this Jun 12, 2021
@vancemiller vancemiller requested a review from BDHU June 12, 2021 19:23
@vancemiller
Copy link
Contributor Author

The default cmake on Ubuntu 20.04 is 3.16, so this is probably not good to merge now. There might be another workaround.

@vancemiller
Copy link
Contributor Author

Or if we want to use the latest and greatest cmake, just include some instructions with the setup script on how to get it.

Copy link
Member

@BDHU BDHU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will probably take a look into this. It will be optimal if the user doesn't have to manually upgrade the distro's cmake to accommodate the need to generate correct gencode flags. Since not all distros use apt as their package manager it might be hard to cover all use cases on Linux correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants