-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional learned vtr for Warthog #226
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Some clean up of comments to do.
-
Need to resolve how to use Git LFS for the model weights.
if (fully_matched && channel.cameras.size() == 2) | ||
// return extractStereoFeaturesDisp(channel, channel_disp); | ||
if (fully_matched && channel.cameras.size() == 2){ | ||
// CLOG(DEBUG, "stereo.learned_features") << "made it here"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove please.
|
||
return F::grid_sample(disparity, keypoints_norm, options).reshape({-1}); | ||
return output; | ||
// return F::grid_sample(disparity, keypoints_norm, options).reshape({-1}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could drop to a single line again and remove the comment.
} | ||
cv::Mat floatDisp; | ||
disp.convertTo(floatDisp, CV_32F, 1.0f / disparity_multiplier); | ||
// CLOG(DEBUG, "stereo.learned_features") << "disp_type " << disp.type(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comments please.
@@ -639,6 +636,10 @@ ChannelFeatures LFE::extractStereoFeaturesDisp(const cv::Mat &left_img, | |||
|
|||
// Get disparity for each keypoint | |||
torch::Tensor disparity = getDisparityTensor(disp); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove please.
No description provided.