Gracefully handle connection timeouts for registrars that point to non-functional WHOIS servers #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 3 3
Lines 78 78
=======================================
Hits 71 71
Misses 7 7 ☔ View full report in Codecov by Sentry. |
…n-functional WHOIS servers
This fixes an issue see with the `pairdomains.com` registrar, whose WHOIS record terminate with a record that includes this:
```
Registrar WHOIS Server: pairdomains.com
```
The actual WHOIS server for the registrar is `whois.pairdomains.com`, so prior to this patch, `Whois.lookup/1` would fail after 60 seconds with `{:error, :timed_out}`. Now, we'll fall back to the most recent successfully retrieved record after `:connect_timeout` (10 seconds by default).
s3cur3
force-pushed
the
connect-timeout
branch
from
60964d0 to
94ca739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue see with the
pairdomains.comregistrar, whose WHOIS record terminate with a record that includes this:The actual WHOIS server for the registrar is
whois.pairdomains.com, so prior to this patch,Whois.lookup/1would fail after 60 seconds with{:error, :timed_out}. Now, we'll fall back to the most recent successfully retrieved record after:connect_timeout(10 seconds by default).