Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sycl examples and bugfixes #1126

Merged
merged 10 commits into from
Jan 19, 2024
Merged

More sycl examples and bugfixes #1126

merged 10 commits into from
Jan 19, 2024

Conversation

Ellen-Wittingen
Copy link

Added two full SYCL examples to the examples folder.

New features:

  • Ported Lars' C implementation for declarations of literal arrays to C++.

Fixed the following bugs:

  • Injectivity of linearization methods is now assumed (the proof is in my thesis report)
  • Fixed data accessor type always being an integer instead of the given type by the user
  • Fixed misinterpretation: kernels that read a buffer should not be waited on when the buffer is destroyed
  • Restricted & to only be ignored for sycl::handler parameters instead of parameters of all types to minimize the amount of inaccurate behaviour

One thing to note is that the full example MatrixTransposeWithF.cpp fails to establish the preconditions of the second kernel about 1 out of 5 times (most likely due to VerCors heuristics not instantiating one of the quantified conditions). However, because it is in the examples folder there must be a test for it. But that means that that test fails 1 in 5 times as well.

This is my last pull request on the SYCL project

@pieter-bos
Copy link
Member

Thanks for all your contributions, and congratulations on the degree :)

@pieter-bos pieter-bos merged commit 1dcceae into dev Jan 19, 2024
8 of 14 checks passed
@pieter-bos pieter-bos deleted the sycl-examples-and-bugfixes branch January 19, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants