Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate carbon #577

Merged
merged 17 commits into from
Feb 11, 2021
Merged

Reinstate carbon #577

merged 17 commits into from
Feb 11, 2021

Conversation

bobismijnnaam
Copy link
Contributor

This PR reinstates the carbon back end. It also splits a test that verifies for carbon but not for silicon into two, namely the KeYAbruptVerificationChallenge example.

- Add separate tests for KeyAbruptTerminationChallenge, one that fails for silicon and one that passes for carbon.
- Added methods for extracting the current version for mono and checking mono requirements for carbon.
- Extended MessageProcess and others run in one go and return all output in one go.
@bobismijnnaam
Copy link
Contributor Author

Carbon is mostly functional at this point. It only does not seem to work properly with the test suite yet. This might have to do with running parallel instances of carbon, not sure. It still needs some investigating. But running single examples should work.

@bobismijnnaam bobismijnnaam temporarily deployed to Default January 26, 2021 16:17 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default January 26, 2021 16:17 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 8, 2021 16:40 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 8, 2021 16:40 Inactive
@bobismijnnaam
Copy link
Contributor Author

I have not been able to reproduce the parallel tests problem, so it seems that this branch is ready for review and merging.

@bobismijnnaam bobismijnnaam temporarily deployed to Default February 8, 2021 16:42 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 8, 2021 16:42 Inactive
@bobismijnnaam bobismijnnaam marked this pull request as ready for review February 8, 2021 16:42
@bobismijnnaam
Copy link
Contributor Author

When reviewing, be sure to filter out .pdb and .dll using the built-in github filter for readability.

@bobismijnnaam bobismijnnaam temporarily deployed to Default February 8, 2021 16:56 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 8, 2021 16:56 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 8, 2021 17:09 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 8, 2021 17:09 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 08:38 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 08:38 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 09:06 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 09:17 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 09:17 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 09:26 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 09:37 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 09:37 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 09:48 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 9, 2021 09:48 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 11, 2021 10:48 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default February 11, 2021 10:48 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bobismijnnaam bobismijnnaam merged commit d7e8a4e into dev Feb 11, 2021
@bobismijnnaam bobismijnnaam deleted the add-carbon-comment-KeY-abrupt branch February 11, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants