Issue 449 - sonarcloud

[Vescatur]

The things changed for sonar are

Disable git shallow copy which ensures that sonar has all the source control management information.
All rules with tag convention are now at severity level blocker.
There are no blocker issues allowed.
Remove rules todo.
Updated the wiki to add sonarlint. https://github.com/utwente-fmt/vercors/wiki/IDE-Import#configure-sonarlint-for-vercors-in-intellij

I am not sure whether this should close #449? I think we should close it and create new issues if we want to make additional changes.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[bobismijnnaam]

What does sonarcloud need the deep git fetch for? It does roughly 10+ seconds to the process (which doesn't matter in the big picture, but might as well keep an eye on the small gains while we're at it)

[bobismijnnaam]

Besides that, the sonarcloud changes look good, and the wiki too.

[ArmborstL]

FYI: The wiki is actually a separate git repository (even if GitHub displays them together on this website). So that's not really related to this pull request. You can also use the wiki as a git repo (with commits, git log, etc) with the URL you see on the right underneath the sidebar. Or you edit it directly via the web interface.
I looked at the new wiki section about sonarLint. Nice to have that, thanks 🙂 I didn't try to reproduce it (yet), so no comments on the content. Language-wise, there are a few things (e.g. first sentence has "warnings" twice, one of the points says "expect" instead of "except", etc.). I can work on those editorial changes later (probably tomorrow) if you like 🙂

[Vescatur]

What does sonarcloud need the deep git fetch for? It does roughly 10+ seconds to the process (which doesn't matter in the big picture, but might as well keep an eye on the small gains while we're at it)

Good eye. It will use the extra information when marking a code smell. It specifies who the author is and when it is created. The creation time of an issue is now the moment SonarCloud scans the code in the future this will be the creation time of the commit. If we wanted to I could split the build and the SonarCloud but the ci will be doing duplicate work and only a small performance gain.

[Vescatur]

FYI: The wiki is actually a separate git repository (even if GitHub displays them together on this website). So that's not really related to this pull request. You can also use the wiki as a git repo (with commits, git log, etc) with the URL you see on the right underneath the sidebar. Or you edit it directly via the web interface.
I looked at the new wiki section about sonarLint. Nice to have that, thanks 🙂 I didn't try to reproduce it (yet), so no comments on the content. Language-wise, there are a few things (e.g. first sentence has "warnings" twice, one of the points says "expect" instead of "except", etc.). I can work on those editorial changes later (probably tomorrow) if you like 🙂

I suppose changes to the wiki and the configuration of sonarcloud do not require a pull request but I thought it was nice if somebody could review it. It is nice that you already caught some mistakes. If you could try the instructions out and work on editorial changes that would be nice.

[bobismijnnaam]

It specifies who the author is and when it is created.

Great, that's a nice benefit, thanks.

[ArmborstL]

If you could try the instructions out and work on editorial changes that would be nice.

I tried it out and it worked (I expected that maybe I would have issues to get SonarCloud access, but it all worked fine) 🙂
I added some additional info to the wiki section, and did some editorial work (a bit of rephrasing and putting more structure to it). Feel free to change whatever you don't like about it 😉

[Vescatur]

If you could try the instructions out and work on editorial changes that would be nice.

I tried it out and it worked (I expected that maybe I would have issues to get SonarCloud access, but it all worked fine) 🙂
I added some additional info to the wiki section, and did some editorial work (a bit of rephrasing and putting more structure to it). Feel free to change whatever you don't like about it 😉

Looks good :)