Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 449 remove commented code #648

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Conversation

Vescatur
Copy link
Contributor

@Vescatur Vescatur commented Jul 7, 2021

This is related to #449 but does not close it.
This branch removes all the commented code. (The branch name is a bit misleading.)

@Vescatur Vescatur temporarily deployed to Default July 7, 2021 10:26 Inactive
@Vescatur Vescatur temporarily deployed to Default July 7, 2021 10:44 Inactive
@Vescatur Vescatur temporarily deployed to Default July 7, 2021 10:54 Inactive
@Vescatur Vescatur temporarily deployed to Default July 7, 2021 10:54 Inactive
@bobismijnnaam
Copy link
Contributor

please keep the comments in the following files: checkprocessalgebra, cslencoder, sequenceutils, and silverbackend. The first three have some significance w.r.t. soundness/features we used to support. SilverBackend contains some options for viper that are nice to keep around, but if you really want to get rid of the comments maybe you can turn this last one into an actual command line option?

@Vescatur Vescatur temporarily deployed to Default July 7, 2021 11:58 Inactive
@Vescatur Vescatur temporarily deployed to Default July 7, 2021 11:58 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bobismijnnaam
Copy link
Contributor

Thanks 👍

@Vescatur Vescatur merged commit a7afff1 into dev Jul 8, 2021
@pieter-bos pieter-bos deleted the issue-449-remove-unused-code branch February 10, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants