-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 509 slow tests #649
Issue 509 slow tests #649
Conversation
…ue-509-slow-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
monotonicbool.pvl should work by now, could you double check if does, and if so remove it from the problem-fail suite? The rest looks great, nice work.
unfortunatly not. This is the output.
|
Kudos, SonarCloud Quality Gate passed! |
Okay, I've handled monotonicBool in the problem-fail PR. I'll also review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Quite a few new problem-fails we'll have to look at why they are broken...
This pull request ensures that the slow tests are run each time a pull request is accepted.
In this commit the slow tests are run. https://github.com/utwente-fmt/vercors/runs/2840658941 Note that problem fail test also ran but that part has been removed from the ci.
One of the tests can be fixed by code from Bob. #509 (comment) However I did not include this code because the scope of the pull request is to run the slow tests. It is not the goal to fix all the tests. It would also cause me to be the author of code which Bob has wrote. I would suggest that Bob makes a pull request to fix this example.