Disable casting in parblockencoder #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We sum with int instead of float in summation.c, since float hasn't been support for a while. Since we only support int, casting is not necessary. This also happens to avoid triggering some java type logic which is interfering.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parblockencoder inserts a cast like
((int) 0)for some examples (in particular,summation.c). Since floats are not supported, this cast is unnecessary, so it can be removed. This cast triggers also some inheritance code logic, which results in a broken program. To avoid that problem for now, the cast is also best removed. Hopefully in the future when the inheritance logic is better maybe the cast can be enabled again, such that if we want to also support floats for this we can implement it.This PR relies on a fix in #658 (namely, trigger generation for programs using
Reducibleis not correct). When that PR is merged, this PR will start succeeding, and then this can be merged.