Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth Route Redirect through React Router #87

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Auth Route Redirect through React Router #87

merged 1 commit into from
Oct 25, 2022

Conversation

handsomelatino
Copy link
Contributor

@handsomelatino handsomelatino commented Oct 24, 2022 •
edited
Loading

  • Auth Route Component redirects to landing page (/) if user is not logged in. Even though redirect is set on the PHP side if user is not authed, unlogging and pressing "back" or revisiting a previous auth-user only route would still show the route and crash React.
  • Bugfix: A non-existing profile would show both skeleton loader and "not found" mesage.

Screen Shot 2022-10-23 at 6 17 52 PM

  • Bugfix: On a same non-existing profile, going to the 'view dashboard' route through the hamburger menu would still show the not found profile.

@handsomelatino
- Auth Route Component redirects to landing page (/) if user is not…
70c195f 
… logged in

- Bugfix: A non-existing profile would show both skeleton loader and "not found" mesage.
- Bufix: On a same non-existing profile, going to the 'view dashboard' route through the hamburger menu would still show the not found profile.
@handsomelatino handsomelatino changed the title - Auth Route Component redirects to landing page (/) if user is not… Auth Route Redirect through React Router Oct 24, 2022
@utxo-one utxo-one merged commit aa1aa07 into utxo-one:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@handsomelatino @utxo-one