Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use constants to replace local variables #211

Merged
merged 1 commit into from
Aug 26, 2024
Merged

refactor: use constants to replace local variables #211

merged 1 commit into from
Aug 26, 2024

Conversation

ShookLyngs
Copy link
Collaborator

Changes

  • Replace local isMainnet and testnetType variables with constants IS_MAINNET and TESTNET_TYPE
  • Replace local rgbpp-lock related methods with utils like getRgbppLock and isRgbppLock
  • Replace local btc-time-lock related methods with utils like getBtcTimeLock and isBtcTimeLock
  • Replace config.predefined.LINA to config.MAINNET and config.predefined.AGGRON4 to config.TESTNET
  • Fix some minor typos

@self-host-2024
Copy link

self-host-2024 bot commented Aug 22, 2024 •
edited
Loading

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-08-22 10:03:03 CET

@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
btc-assets-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 10:02am

@Flouse Flouse merged commit cb25b92 into develop Aug 26, 2024
2 of 4 checks passed
@Flouse Flouse deleted the ref/simplify-constants branch August 26, 2024 08:43
@ShookLyngs ShookLyngs mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dawn-githup Dawn-githup Dawn-githup approved these changes

@Flouse Flouse Flouse approved these changes

@ahonn ahonn Awaiting requested review from ahonn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShookLyngs @Flouse @Dawn-githup