Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add authentication for token routes #3

Merged
merged 1 commit into from
Mar 12, 2024
Merged

feat: add authentication for token routes #3

merged 1 commit into from
Mar 12, 2024

Conversation

ahonn
Copy link
Collaborator

@ahonn ahonn commented Mar 6, 2024

For development/test env:

  • always show token routes in swagger docs
  • generate token without authentication

For production env:

  • hide token routes in swagger docs
  • generate token require authentication (Basic Base64({ADMIN_USERNAME}:{ADMIN_PASSWORD}))

@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
btc-assets-api ✅ Ready (Inspect) Visit Preview Mar 7, 2024 0:34am

@ahonn ahonn changed the base branch from main to develop March 6, 2024 02:59
@ahonn ahonn requested a review from yuche March 6, 2024 09:02
@ahonn ahonn force-pushed the feat/token-api-auth branch from a365835 to 13230d2 Compare March 7, 2024 00:33
@ahonn ahonn merged commit c83d4d3 into develop Mar 12, 2024
1 check passed
@ahonn ahonn mentioned this pull request Mar 19, 2024
Merged
@ahonn ahonn deleted the feat/token-api-auth branch April 1, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuche yuche Awaiting requested review from yuche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahonn