-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(btc|service): support internal query data caching in TxBuilder.payFee() #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are some suggestions from @ahonn:
|
…o true by default when paying fee
ahonn
approved these changes
May 24, 2024
Flouse
reviewed
May 24, 2024
Flouse
approved these changes
May 24, 2024
Dawn-githup
approved these changes
May 24, 2024
duanyytop
approved these changes
May 24, 2024
Just renamed the cache-related options to make them look clearer:
|
The problem can be broken down into two parts:
|
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Query data cache
Previously, when collecting inputs for paying fees, the
BtcAssetsApi.getBtcUtxos()
API and theBtcAssetsApi.getRgbppAssetsByBtcUtxo()
API were queried multiple times. In this PR, a DataCache is added to prevent querying the same API with the same params too often.Reference: #173 (comment)
Test