-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ckb|example): Export buildRgbppTransferTx
from rgbpp package and update L1 transfer example
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShookLyngs
requested changes
Jun 4, 2024
Flouse
previously approved these changes
Jun 6, 2024
ShookLyngs
reviewed
Jun 6, 2024
ShookLyngs
previously approved these changes
Jun 6, 2024
ShookLyngs
previously approved these changes
Jun 6, 2024
Flouse
previously approved these changes
Jun 6, 2024
duanyytop
force-pushed
the
feat/rgbpp-package-l1-transfer
branch
from
June 6, 2024 14:30
42699bd
to
4893d8f
Compare
I fixed the conflicts between this branch and develop branch and then it needs to be reviewed again. |
6 tasks
ShookLyngs
requested changes
Jun 6, 2024
ShookLyngs
approved these changes
Jun 7, 2024
Flouse
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
buildRgbppTransferTx
from rgbpp package to generate CKB virtual TX and BTC tx to be signedbuildRgbppTransferTx
Function Signature
The
collector
andbtcDataSource
will be constructed in thergbpp-sdk-service
with some necessary variables from the environment. The necessary request and response for the L1 transfer in thergbpp-sdk-service
are as follows:Related PR