This repository has been archived by the owner on Aug 14, 2022. It is now read-only.
update dependencies, migrate to Ktor 2 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
utybo
suggested changes
Jun 29, 2022
There was a problem hiding this comment.
Thank you very much for this PR! I've left a comment, but this is mostly the same thing that the CI is telling you (you can reproduce the CI's warnings locally with gradle check).
As for the /swagger, problem, you actually need to go to /swagger/ in order for your browser to correctly resolve relative Swagger UI links. It's a bit awkward, and it's something that I'll file an issue about asap Done: #8 .
utybo
reviewed
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the dependencies and "migrated" everything to Ktor 2.
I just cant seem to get the swagger UI running
Opening
/swaggerjust displays an empty page.