Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for standard flag #17

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Conversation

karthikraobr
Copy link
Contributor

This PR adds support for determining if a package is a part of the standard library.

@uudashr
Copy link
Owner

uudashr commented Oct 8, 2019

Is there any use case for this?

@karthikraobr
Copy link
Contributor Author

karthikraobr commented Oct 8, 2019

Is there any use case for this?

microsoft/vscode-go#2803 especially this comment I am not sure if this could be considered a good enough use case?

@uudashr
Copy link
Owner

uudashr commented Oct 10, 2019

Ramya suggests to use Dir and compare with GOROOT, the workaround should works. Do you think we still need to expose {{.Standard}} or exposing it is the better way?

@karthikraobr
Copy link
Contributor Author

Ramya suggests to use Dir and compare with GOROOT, the workaround should works. Do you think we still need to expose {{.Standard}} or exposing it is the better way?

I am not quite sure. I already am working on the Dir workaround. Do you think adding {{.Standard}} would add a significant overhead? If not I guess we could keep it right?

@uudashr
Copy link
Owner

uudashr commented Oct 10, 2019

Should ok. We still have fail on travis check here. I might not available in around 2 or 3 days, so it would be good if you can check and fix it so I can merge your changes as soon as possible.

@nezorflame
Copy link
Contributor

Travis will be fixed once #18 is merged

@uudashr uudashr merged commit 6b94cfd into uudashr:master Oct 15, 2019
@karthikraobr karthikraobr deleted the feature/StdLib branch October 16, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants