Serialize to binary if the serde format is not human readable #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2017 13:13
This uses the [is_human_readable](https://github.com/serde-rs/serde/releases/tag/v1.0.16) method added in serde 1.0.16 to serialize uuid's in a more compact form if the serialized format does not need to be human readable. (Maybe) related uuid-rs#90 BREAKING CHANGE If serde serialization is used with non-human-readable format then uuid's will be serialized as bytes instead of strings
|
Awesome, thanks! I wonder though, is this actually a breaking change? If the serialization changed for |
|
Ah, right. It is only for formats setting |
|
Ok! In that case I'm gonna merge this as it looks great! |
Marwes
pushed a commit
to Marwes/uuid
that referenced
this pull request
Nov 7, 2017
Ended up completing the compact/readable serde_test API so here are the tests missing from uuid-rs#104. I also replaced the `serde_json` roundtrip test with plain `assert_tokens` tests which do essentially the same thing. I can re-add it if it seems worthwhile to keep it though.
|
Could we get a crates.io release with this? (Is there a better way to request/indicate a crates.io release in stable/slow moving crates such as this?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
is_human_readable
method added in serde 1.0.16 to serialize uuid's in a more compact
form if the serialized format does not need to be human readable.
This does not have an explicit test for
is_human_readable == falsesince serde-rs/test#12 has not been completed for serde_test so you may want to wait with merging. I have verified it manually though.(Maybe?) related serde-rs/serde#90