-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sha1 to 0.5 #142
Update sha1 to 0.5 #142
Conversation
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Kindly check if the repo has any breaking changes that affect us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like sha1 did two things in 0.5:
- add serde support (no effect on uuid)
- bump rand to 0.4
The README for rand states that 0.4 "contains almost no breaking changes since the 0.3 release", and that it mostly just added new features.
I will check the changes in between the two versions of rand |
I think we're safe either way here, because |
The only major one I see is the switch to |
bors: r+ |
I actually thought that you would reuse serde feature ;) |
Also it has std, so you at least should change |
I can create a separate pr for that.. That was outside the scope of the issue |
closes #141