Bring back the renamed use_std feature for backwards compat
#157
Conversation
sgrif
requested review from
Dylan-DPC-zz,
kinggoesgaming,
KodrAus and
radix
as code owners
|
Ah my bad! I thought that feature was already published in the deprecated state. Do you mind adding a comment to the toml to note that it's a shim for compatibility between |
addaecd removed this feature, which was intentionally left deprecated for backwards compatibility. This "cleanup" removed a deprecated feature before any released version actually had the deprecation present. Removing this feature makes it impossible for other crates to support UUID 0.6 without dropping support for UUID 0.5 and earlier. This is a major problem for crates like Diesel, which are post-1.0
|
Done! |
sgrif
force-pushed
the
sg-use-std-shim
branch
from
34907f5
to
6975284
Compare
|
Note though we will most likely remove it before 1.0. Should be enough time for crates to adapt |
|
I would argue that keeping this compatibility shim is incredibly low maintenance, and is worth keeping given that this is a crate that is likely to be a public dependency of others. But ultimately it's your call :) |
|
@sgrif I would love to have it removed in Something like As After discussion with @KodrAus, we decided to leave that as a release notes warning |
|
bors r+ |
157: Bring back the renamed `use_std` feature for backwards compat r=KodrAus a=sgrif addaecd removed this feature, which was intentionally left deprecated for backwards compatibility. This "cleanup" removed a deprecated feature before any released version actually had the deprecation present. Removing this feature makes it impossible for other crates to support UUID 0.6 without dropping support for UUID 0.5 and earlier. This is a major problem for crates like Diesel, which are post-1.0
|
hi @sgrif thanks for the PR. This is something that slipped through. We will maintain the compatibility shim in future releases.
@kinggoesgaming yeah true but then users won't know about it. Not everyone will check the toml file. Instead we can put a warning in the docs & readme. |
|
Wouldn't you be able to use the semver-trick to remove the feature flag from new releases while keeping backwards compatibility? |
addaecd
removed this feature, which was intentionally left deprecated for
backwards compatibility. This "cleanup" removed a deprecated feature
before any released version actually had the deprecation present.
Removing this feature makes it impossible for other crates to support
UUID 0.6 without dropping support for UUID 0.5 and earlier. This is a
major problem for crates like Diesel, which are post-1.0