Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add issue and PR templates #162

Merged
merged 4 commits into from
Mar 5, 2018
Merged

add issue and PR templates #162

merged 4 commits into from
Mar 5, 2018

Conversation

kinggoesgaming
Copy link
Member

@kinggoesgaming kinggoesgaming commented Mar 4, 2018

Issues:

/issues/new: Use the default issue template.
/issues/new?template=bug: Use the bug report template.
/issues/new?template=feature: Use the feature request template.
/issues/new?template=tracker: Use the tracker template. Only for us to use.


PRs:

/pulls/new: Use the default PR template.
/pulls/new?template=release: Use the release preparations template. Our own use only.


Also makes having an issue for any PR a requirement. I have that so that as part of stabilization, we don't just go overboard with features and such.

closes #116

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming kinggoesgaming added this to the 0.6.2 milestone Mar 4, 2018
@kinggoesgaming kinggoesgaming self-assigned this Mar 4, 2018
@kinggoesgaming kinggoesgaming requested a review from a team March 4, 2018 21:45
Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I just left a single nitpick about one of the checkbox lists.

Feel free to fix/ignore that then r+.

imcomplete, prepend the Title with WIP:
-->

**I'm submitting a ...**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: This might read a bit better if we change the checkboxes to be singular. So instead of bug fixes we'd say bug fix. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Mar 5, 2018
162: add issue and PR templates r=kinggoesgaming a=kinggoesgaming

Issues:

[`/issues/new`]: Use the default issue template.
[`/issues/new?template=bug`]: Use the bug report template.
[`/issues/new?template=feature`]: Use the feature request template.
[`/issues/new?template=tracker`]: Use the tracker template. Only for us to use.

[`/issues/new`]: https://github.com/uuid-rs/uuid/issues/new
[`/issues/new?template=bug`]: https://github.com/uuid-rs/uuid/issues/new?template=bug
[`/issues/new?template=feature`]: https://github.com/uuid-rs/uuid/issues/new?template=feature
[`/issues/new?template=tracker`]: https://github.com/uuid-rs/uuid/issues/new?template=tracker

---
PRs:

[`/pulls/new`]: Use the default PR template.
[`/pulls/new?template=release`]: Use the release preparations template. Our own use only.

[`/pulls/new`]: https://github.com/uuid-rs/uuid/pulls/new
[`/pulls/new?template=release`]: https://github.com/uuid-rs/uuid/pulls/new?template=bug

---
Also makes having an issue for any PR a requirement. I have that so that as part of stabilization, we don't just go overboard with features and such.

closes #116
@bors
Copy link
Contributor

bors bot commented Mar 5, 2018

@bors bors bot merged commit fc0195e into master Mar 5, 2018
@kinggoesgaming kinggoesgaming deleted the template branch March 5, 2018 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add issue, pr templates
2 participants